luci-app-ddns: show the URL which will be used. #7559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Pazdziora <[email protected]>
|
This can also be considered as a fix for #5297. |
This was referenced Jan 11, 2025
|
In #3582 folks suggest that LuCI should parse the URL for the If we don't plan to do that (or do that right now) and we start to show the URL in the UI with this PR, could we make all the currently-mandatory fields optional? And basically make it the responsibility of the user to fill in the fields used in the URL, based on the hints in under the fields? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: <[email protected]>row (viagit commit --signoff)<package name>: titlefirst line subject for packagesPKG_VERSIONin the MakefileReplaces [DOMAIN] in Update-URL (URL-encoded)comments. It's certainly nice to have that information but I always wondered "what is that Update-URL?" for this service? Then I came across luci-app-ddns: Namecheap DDNS setting are misleading #2436 which basically discusses that this DDNS provider does not use username and expects host (?) instead. We likely cannot finetune the description of the fields in the UI to this case but maybe if we actually showed the admin the Update-URL which will be used, it might be easier for them to figure out which field to use for what.